summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNiels Thykier <niels@thykier.net>2017-07-30 10:29:13 (GMT)
committerNiels Thykier <niels@thykier.net>2017-07-30 10:29:13 (GMT)
commite2c420df3aa600c6af1c734970227c2ee2a90e90 (patch)
tree715f98979b57acf9250412a6ff419cc0a69c29ba
parent4569d0eb8c1b506bde72c76dfb089bd71d324cf6 (diff)
Dh_Lib: Force doit to not use shells with exec
Signed-off-by: Niels Thykier <niels@thykier.net>
-rw-r--r--Debian/Debhelper/Dh_Lib.pm4
-rw-r--r--debian/changelog7
2 files changed, 10 insertions, 1 deletions
diff --git a/Debian/Debhelper/Dh_Lib.pm b/Debian/Debhelper/Dh_Lib.pm
index 6e8c630..60a5422 100644
--- a/Debian/Debhelper/Dh_Lib.pm
+++ b/Debian/Debhelper/Dh_Lib.pm
@@ -325,7 +325,9 @@ sub _doit {
open(STDOUT, '>', $output) or error("redirect STDOUT failed: $!");
}
}
- exec(@cmd);
+ # Force execvp call to avoid shell. Apparently, even exec can
+ # involve a shell if you don't do this.
+ exec { $cmd[0] } @cmd;
}
return waitpid($pid, 0) == $pid && $? == 0;
}
diff --git a/debian/changelog b/debian/changelog
index 5d370f8..7798742 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+debhelper (10.7.1) UNRELEASED; urgency=medium
+
+ * Dh_Lib: Fix doit's new call to ensure it does not call a shell
+ (like the documentation promises).
+
+ -- Niels Thykier <niels@thykier.net> Sun, 30 Jul 2017 10:27:46 +0000
+
debhelper (10.7) unstable; urgency=medium
[ Niels Thykier ]