Skip to content
Commit 88753aea authored by Jonas Smedegaard's avatar Jonas Smedegaard
Browse files

Revert (possibly) ill-adviced changes to copyright file

Commit consisted of several changes, vaguely described as "Improve it":

 a) Switch of "Upstream-Contact" from issue tracker to personal email
 b) Removal of alternative upstream source URL
 c) Removal of repackaging notice from Source field
 d) Move of verbatim licensing from Files section to License section
 e) Indentation change from single space to vertically aligned

Regarding a):

The "Upstream-Contact" field is for listing the preferred form of
contact.  Generally I consider that to be the first available of these:

 * contact form explicitly stated as such by upstream
 * upstream issue tracker
 * upstream developers' mailinglist
 * upstream general mailinglist
 * personal email of main upstream author

Regarding b):

I see no need for or improvement in removing alternative source URL.

Regarding c):

Machine-readable file format mandates Source field to include mention of
repackaging.

Regarding d):

The "...same as Perl..." statement common for perl modules is a
licensing statement and should therefore be included verbatim, but it is
not a license (neither GPL nor Artistic specifically) so does not belong
in a License section.  See bug#786450 for more recent and less confusing
pattern addressing this.

Regarding e):

Indentation style is subjective.  I prefer avoiding excess space except
left-most for indentation (where I prefer TAB over space when allowed).

I see no need for or improvement in changing indentation style, and find
it wrong to do so without coordination with peer package maintainers
(i.e. those listed in Uploaders field in control file).

For each of above, if insisting on the change then please re-commit each
logic change _separately_ with _descriptive_ commit message (single-line
commit message ok but virtually empty message is rarely if ever fine).

This reverts commit c254e243.
parent 9bdc26a0
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment