Produce better error messages with invalid lab queries

Signed-off-by: Niels Thykier <niels@thykier.net>

Fix embedded-library false-positive for tiff3

Signed-off-by: Niels Thykier <niels@thykier.net>

Remove references to yada as it is being removed

Signed-off-by: Niels Thykier <niels@thykier.net>

Added override for build-depends-on-python-dev-with-no-arch-any

We need the python-all-dev build-dependency for the test suite.

Signed-off-by: Niels Thykier <niels@thykier.net>

Added check for python-numpy ABI dependency

Signed-off-by: Niels Thykier <niels@thykier.net>

Refresh data files and re-generate ftp-master profile

Signed-off-by: Niels Thykier <niels@thykier.net>

Update ANCIENT_DATE of Standard-Versions

Signed-off-by: Niels Thykier <niels@thykier.net>

Clarified the C.UTF-8 situation in the manual(s)

Signed-off-by: Niels Thykier <niels@thykier.net>

Fix some typoes and misuses of "i.e."

Signed-off-by: Niels Thykier <niels@thykier.net>

Make copyright-with-old-dh-make-debian-copyright pedantic

Signed-off-by: Niels Thykier <niels@thykier.net>

Further copyright-with-old-dh-make-debian-copyright wording tweaks

source-copyright: Use line numbers instead of paragraph numbers

Signed-off-by: Niels Thykier <niels@thykier.net>

Util.pm: Report line number in syntax errors of dctrl files

Signed-off-by: Niels Thykier <niels@thykier.net>

Clarify the legal status of copyright notices in long tag desc

* checks/copyright.desc:
  + [RA] Rephrase copyright-with-old-dh-make-debian-copyright long
    description to be clearer about the legal status of copyright
    notices.  (Closes: #659574)

dh_commnads-manual: Added entry for dh_xine

Signed-off-by: Niels Thykier <niels@thykier.net>

L::Tags::_record_stats: Count experimental tags separately

Count experimental tags as a separate group of tags.  This fixes an
issue where Lintian would exit 1 if the only error tags emitted were
experimental.

Signed-off-by: Niels Thykier <niels@thykier.net>

Remove internal locale on upgrade/trigger if no longer needed

Added a trigger on /usr/lib/locale/C.UTF-8 locale to catch cases like
libc-bin being upgraded to 2.13 after Lintian 2.5.5.  Prefer libc-bin
(>= 2.13) to locales in dependencies.

Signed-off-by: Niels Thykier <niels@thykier.net>

p/runtests: Generate en_US.UTF-8 locale instead of C.UTF-8

It is not possible to generate the C.UTF-8 locale on Squeeze systems
and Lintian needs either C.UTF-8 or en_US.UTF-8 to pass the certain
tests (like manpages-general).

Signed-off-by: Niels Thykier <niels@thykier.net>

p/runtests: Generate locale only if needed

Signed-off-by: Niels Thykier <niels@thykier.net>

Util: Fix stupid error in clean_env

Signed-off-by: Niels Thykier <niels@thykier.net>

checks/infofiles: Use clean_env after fork

Signed-off-by: Niels Thykier <niels@thykier.net>

Util: Make clean_env optionally set LC_ALL

Signed-off-by: Niels Thykier <niels@thykier.net>

Util: Added clean_env sub to clean %ENV using a whitelist

Signed-off-by: Niels Thykier <niels@thykier.net>

Added test for no-upstream-changelog

The check was lost as a side-effect of commit dde19e4.

Signed-off-by: Niels Thykier <niels@thykier.net>

Check for ELF binaries in unsafe paths in M-A same packages

Modification to original patch:
 * Also assume "/.build-id/" dirs to be safe.

Signed-off-by: Niels Thykier <niels@thykier.net>

Treat pedantic the same as all other severities

Signed-off-by: Niels Thykier <niels@thykier.net>

Add checks for certainty and severity in L::T::Info::new

This catches an incorrect .desc file for checks as soon as it is
loaded.  It also makes a couple of other "certainty/severity" checks
redundant.

Signed-off-by: Niels Thykier <niels@thykier.net>

L::Profile: s/turth/truth/ fix

Signed-off-by: Niels Thykier <niels@thykier.net>

lintian: Reduce the use of L::DepMap for checks

Signed-off-by: Niels Thykier <niels@thykier.net>

lintianrc.example: Remove deprecated vars and add TMPDIR

Signed-off-by: Niels Thykier <niels@thykier.net>

lintian: Allow TMPDIR in the configuration file

Signed-off-by: Niels Thykier <niels@thykier.net>

lintian: Fixed a regression in parsing LINTIAN_ conf options

Remove a leftover '$var = "LINTIAN_$var"' that broke the names
of some (apparently unused) configuration options.

Signed-off-by: Niels Thykier <niels@thykier.net>

Lab: Fix tempdir invocation and extended the tempdir template

Fix the call of tempdir in L::Lab::create so it actually receives the
options passed to it.  Also extended the randomizable part of the
template to 10 (from 6).

Signed-off-by: Niels Thykier <niels@thykier.net>

Work around dpkg-source hardcoding gpg{,v} paths

dpkg-source hardcodes the paths to gpg (and gpgv).  To fix this,
harness exports a magic/internal env variable if signature checks are
to be skipped.

Signed-off-by: Niels Thykier <niels@thykier.net>

lib/Lintian/Processable.pm: add missing word

Signed-off-by: Adam D. Barratt <adam@adam-barratt.org.uk>

Minor fixup of L::Processable{,::Package}

Remove an unused constant and fixed a documentation typo.  Fixed
info caching for L::P::Package and revised L::P info.

Signed-off-by: Niels Thykier <niels@thykier.net>

harness: Also handle gpgv with $LINTIAN_GPG_CHECK

Apparently dpkg-source prefers gpgv to gpg, so ensure that gpgv is
also linked to /bin/true when skipping gpg checks.

Signed-off-by: Niels Thykier <niels@thykier.net>

cruft: Do now open symlinks when checking waf files

Signed-off-by: Niels Thykier <niels@thykier.net>

cruft: Double check waf files if file(1) says ok

Unfortunately file 5.04 (Squeeze) says the waf file in the Lintian
test suite is "python" and not "data".

Signed-off-by: Niels Thykier <niels@thykier.net>

c/file-info: pass -N to file(1) to avoid output alignment

For packages with long filenames the alignment can be a considerably
part of the size (e.g. the lintian/2.5.4 source).

Signed-off-by: Niels Thykier <niels@thykier.net>

Emit spelling tags only once per error per field/file/text

Signed-off-by: Niels Thykier <niels@thykier.net>

harness: Skip sources if there are no binaries referencing them

Signed-off-by: Niels Thykier <niels@thykier.net>

Add separate tag for not having a debhelper compat file

Signed-off-by: Niels Thykier <niels@thykier.net>

Fix ordering of some changelog entries

Signed-off-by: Niels Thykier <niels@thykier.net>

Remove the *-not-full-name checks (Closes: #658031).

Acked-by: Niels Thykier <niels@thykier.net>

Check for commented out collab-maint Vcs-* headers.

dh_make adds commented out Vcs-* header boilerplate to debian/control,
which should either be removed, or changed to be a valid location.

This check implements just that.

Modifications to the original patch:
 - tidied the regex a bit
 - renamed to tag control-file
 - only emit the tag once per file/package

Requested-By: Paul Wise <pabs@debian.org>
Signed-off-by: Gergely Nagy <algernon@balabit.hu>
Signed-off-by: Niels Thykier <niels@thykier.net>

Lintian::Lab: Use section instead of const value for area value

Fixed an issue where the constant "main" was used in the metadata of
binary packages.

Signed-off-by: Niels Thykier <niels@thykier.net>

Fixed TRIPLETT -> TRIPLET typo in various test files

Acked-by: Niels Thykier <niels@thykier.net>

Lintian::Lab: Added repair_lab method

This is able to correct lab indices referring to entries that are
either broken or does not exist.  The solution is to remove the
metadata reference and the remains of the entry (if any).

It lacks a check for packages present in the lab that does not appear
in the relevant index.

Signed-off-by: Niels Thykier <niels@thykier.net>

harness: Skip some actions in dry-run

Signed-off-by: Niels Thykier <niels@thykier.net>

Fix broken Log in dry-run and some uses of Die

In dry-run mode it now opens the LOG descriptor used by the Log
function.  As Die (not to be confused with die) uses Log to output an
error, it should not be used before the log file has been opened.

Signed-off-by: Niels Thykier <niels@thykier.net>

Re-added swfobjects.js to list of known javascript libraries

Signed-off-by: Niels Thykier <niels@thykier.net>

harness: Added --dry-run option

Signed-off-by: Niels Thykier <niels@thykier.net>

harness: Use Getopt::Long for cmd args and add --help

Migrate to Getopt::Long - this means all frontends (that parse
arguments) all use the same option parser.

Add --help/-h for consistency with the other frontends and because
otherwise you would have to give invalid arguments to get usage info.

Signed-off-by: Niels Thykier <niels@thykier.net>

html_reports: Index only source packages in packages_$i.html

This reduces the amount of packages in each "packages_$i.html" a
bit.

Signed-off-by: Niels Thykier <niels@thykier.net>

Ignore missing symbols/shlibs files for libc libnss plugins

Signed-off-by: Niels Thykier <niels@thykier.net>

Updated regex in lib_soname_path

Recognise some libnss plugins are installed in {,usr/}lib{,32,64}.
Remove unneeded check for leading "./" in paths.

Signed-off-by: Niels Thykier <niels@thykier.net>

Added "tls" to hwcap-dirs via "Keep:"

Signed-off-by: Niels Thykier <niels@thykier.net>

shared-libs: Move hwcap-dirs into a data-file

Signed-off-by: Niels Thykier <niels@thykier.net>

Drop usr/X11R6/lib from ldconfig-dirs

It is no longer in /etc/ld.so.conf (nor in the .d dir).

Signed-off-by: Niels Thykier <niels@thykier.net>

Implemented "soruce-contains-waf-binary" tag

Acked-by: Niels Thykier <niels@thykier.net>

Rewrote refresh-archs, auto-generated ldconfig-dirs

Signed-off-by: Niels Thykier <niels@thykier.net>

Fixed a regression in testset/runtests (caused by the last commit)

Signed-off-by: Niels Thykier <niels@thykier.net>

Pass LINTIAN_ROOT to constructor of Lintian::Profile

Signed-off-by: Niels Thykier <niels@thykier.net>

Added changelog entries and uploaded the manpage

Signed-off-by: Niels Thykier <niels@thykier.net>

L::Tags: remove suppress and only methods

Signed-off-by: Niels Thykier <niels@thykier.net>

Replaced %check_info/%enabled_checks with profiles

Signed-off-by: Niels Thykier <niels@thykier.net>

Removed Checker module and reduced the "magic" of LINTIAN_ROOT

The code from the Checker module has been inlined into its own sub in
frontend/lintian.  The extra module did not reduce the size of
f/lintian notabily and it allowed a reduction in the ways we propagate
LINTIAN_ROOT to modules.

Previously LINTIAN_ROOT needed to be exported as an ENV variable AND
as an "our $LINTIAN_ROOT".  Now, only the ENV variable is needed.

Signed-off-by: Niels Thykier <niels@thykier.net>

Made suppress checks and suppress checks go through the profile

The work still duplicated further down in the code, but will be
removed in a later commit.

Signed-off-by: Niels Thykier <niels@thykier.net>

Remove unused code in Lintian::Info::Tag

Removal of the Lintian::Info::Tag (TAG) constructor and the now
redundant _load_tag_data.

Signed-off-by: Niels Thykier <niels@thykier.net>

Always load a profile and stop using Lintian::Info::Tag (TAG)

frontend/lintian will now always load a profile.  This allows
all tag look-ups to go through profiles and removes the need
for the Lintian::Info::Tag (TAG) constructor.

In order to keep this patch small, it leaves some now (almost)
redundant code that will be removed in a later commit (notiably
including the above mentioned constructor).

Signed-off-by: Niels Thykier <niels@thykier.net>

Made profiles a "tag-container" and use profiles more widely

Previously tags were stored in a private static variable in
Lintian::Tags.  Unfortunately, Lintian::Tags, Lintian::Profile and
reporting/html_reports manually accessed the check dir for various
reasons.

To solve this, Lintian::Profile is now the primary method of obtaining
tag info.  There is a single unhandled case in f/lintian (propagating
to Lintian::Tags), where no profile is loaded and the old method is
still used.

Some important changes:
 * Lintian::Profile now applies severity changes directly.
 * Lintian::Tags can work directly with a profile, which reduces a bit
   of glue code between the two modules in f/lintian.
 * The (reporting) templates now get the Lintian profile (as $profile).
   This replaces the "%all" hash (only used to iterate over all known
   tags in r/t/tags-all.tmpl).

Signed-off-by: Niels Thykier <niels@thykier.net>

Added Class for representing "Check Scripts"

Signed-off-by: Niels Thykier <niels@thykier.net>

Fixed an uninitialized variable issue in L::Lab::Entry

Signed-off-by: Niels Thykier <niels@thykier.net>

Allow self relations in Replaces and Provides (per §7.6.2)

Signed-off-by: Niels Thykier <niels@thykier.net>

Gracefully handle syntax errors in debconf templates

Signed-off-by: Niels Thykier <niels@thykier.net>

Gracefully handle syntax errors in d/control

Lintian::Collect::Source will now ignore syntax errors in d/control
(but not other errors).  Instead it will "assume" the file to be
"empty" (for the purpose of determining binaries/binary fields).

Signed-off-by: Niels Thykier <niels@thykier.net>

Added pod to L::Collect::Group and fixed copyright

Signed-off-by: Niels Thykier <niels@thykier.net>

Improved the documentation of Lintian::Lab

Also forbid an empty "Layout" field in L::Lab::open.

Signed-off-by: Niels Thykier <niels@thykier.net>

Removed dh_dhelp-is-deprecated tag

The debhelper package no longer ships dh_dhelp (not even in Squeeze).
According to lintian.d.o, the tag is no longer emitted.

Signed-off-by: Niels Thykier <niels@thykier.net>

Removed two tags related to wm-menu{,-config}

The menu package no longer ships these executables (not even in
Squeeze).  According to lintian.d.o, the tags are no longer
emitted.

Signed-off-by: Niels Thykier <niels@thykier.net>

Removed reference to the removed "unpack" dir in README.dev

Signed-off-by: Niels Thykier <niels@thykier.net>

c/cruft: properly handle unpacked being a symlink

Signed-off-by: Niels Thykier <niels@thykier.net>

Removed assumption unpacked being a regular dir in some colls

Signed-off-by: Niels Thykier <niels@thykier.net>

Typo fix

Signed-off-by: Adam D. Barratt <adam@adam-barratt.org.uk>

Fixed a typo in the changelog

Signed-off-by: Niels Thykier <niels@thykier.net>

More typo fixing

I can't even spell my own name anymore! T_T

Signed-off-by: Niels Thykier <niels@thykier.net>

Explicitly say that profile directories are searched in order

Signed-off-by: Niels Thykier <niels@thykier.net>

Typo fixes in the Manual

Signed-off-by: Niels Thykier <niels@thykier.net>

Recognize more Perl debconf usages

* checks/debconf:
  + [RA] Recognize Perl uses of debconf templates via metaget or
    settitle.

Include ssh:// as valid protocol for hg

Acked-by: Niels Thykier <niels@thykier.net>

lintian-info: Fixed the --profile argument

It now accepts the mandatory parameter it is supposed to.

Signed-off-by: Niels Thykier <niels@thykier.net>

Properly strip comments and empty lines from suppress tags files

Signed-off-by: Niels Thykier <niels@thykier.net>

Reworded two lines of the documentation

Signed-off-by: Niels Thykier <niels@thykier.net>

Refreshed ancient S-V date

Signed-off-by: Niels Thykier <niels@thykier.net>

L::Profile: Improve the "recursive definition"-check

Catch profiles that are recursively defined, but where the Profile
field of the child and Extend field of the parent are not identical.
This can happen if one profile uses "$vendor" and another uses
"$vendor/main" or if symlinks are involved.

This patch solves the issue by deferring the check until the child
profile has been read.  Then it can use the Profile field as the
"canonical" name for the profile.

Note the parents field will use the value in the Extends field and not
the Profile field in the child profile.

Signed-off-by: Niels Thykier <niels@thykier.net>

Corrected any-CPU wildcards for some archs

This is done by mapping architecture names to their "DEB_HOST_ARCH_OS"
and "DEB_HOST_ARCH_CPU" values and using those to determine the
wildcards.

Previously architecture wildcards were determined from the Debian
arch by splitting the architecture by "-" and using the result to
define "OS-any" and "any-CPU".

This relies on the assumption that the CPU wildcard has the exact same
CPU name as the Debian arch.  Unfortunately, this assumption is
invalid for some cases (e.g. armel and lpia)[1].

[1] This can be confirmed by using dpkg-architecture:

 $ dpkg-architecture -aarmel -iany-armel && echo yes
 $ dpkg-architecture -aarmel -iany-arm && echo yes
 yes

 $ dpkg-architecture -alpia -iany-lpia && echo yes
 $ dpkg-architecture -alpia -iany-i386 && echo yes
 yes

Signed-off-by: Niels Thykier <niels@thykier.net>

harness: Set environment variables before including other modules

Signed-off-by: Evan Broder <evan@ebroder.net>

Set $ENV{LINTIAN_ROOT} in generate-lintian-pod

Lintian::Architecture is indirectly loaded and uses Lintian::Data,
which assumes $ENV{LINTIAN_ROOT} is set.  Set $ENV{LINTIAN_ROOT} to
work around the "uninitialized variable" warnings.

Signed-off-by: Niels Thykier <niels@thykier.net>

Documented architecture specific overrides

Signed-off-by: Niels Thykier <niels@thykier.net>