lintian/lintian.git
2 years agoProduce better error messages with invalid lab queries
Niels Thykier [Tue, 21 Feb 2012 08:02:57 +0000 (09:02 +0100)]
Produce better error messages with invalid lab queries

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoFix embedded-library false-positive for tiff3
Niels Thykier [Tue, 21 Feb 2012 07:44:21 +0000 (08:44 +0100)]
Fix embedded-library false-positive for tiff3

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemove references to yada as it is being removed
Niels Thykier [Sun, 19 Feb 2012 23:06:00 +0000 (00:06 +0100)]
Remove references to yada as it is being removed

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdded override for build-depends-on-python-dev-with-no-arch-any
Niels Thykier [Sun, 19 Feb 2012 22:40:23 +0000 (23:40 +0100)]
Added override for build-depends-on-python-dev-with-no-arch-any

We need the python-all-dev build-dependency for the test suite.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdded check for python-numpy ABI dependency
Jakub Wilk [Sun, 19 Feb 2012 22:37:18 +0000 (23:37 +0100)]
Added check for python-numpy ABI dependency

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRefresh data files and re-generate ftp-master profile
Niels Thykier [Sun, 19 Feb 2012 22:02:41 +0000 (23:02 +0100)]
Refresh data files and re-generate ftp-master profile

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoUpdate ANCIENT_DATE of Standard-Versions
Niels Thykier [Sun, 19 Feb 2012 21:44:58 +0000 (22:44 +0100)]
Update ANCIENT_DATE of Standard-Versions

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoClarified the C.UTF-8 situation in the manual(s)
Niels Thykier [Sun, 19 Feb 2012 19:55:50 +0000 (20:55 +0100)]
Clarified the C.UTF-8 situation in the manual(s)

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoFix some typoes and misuses of "i.e."
Niels Thykier [Sun, 19 Feb 2012 19:27:33 +0000 (20:27 +0100)]
Fix some typoes and misuses of "i.e."

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoMake copyright-with-old-dh-make-debian-copyright pedantic
Niels Thykier [Tue, 14 Feb 2012 22:30:44 +0000 (23:30 +0100)]
Make copyright-with-old-dh-make-debian-copyright pedantic

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoFurther copyright-with-old-dh-make-debian-copyright wording tweaks
Russ Allbery [Tue, 14 Feb 2012 21:25:43 +0000 (13:25 -0800)]
Further copyright-with-old-dh-make-debian-copyright wording tweaks

2 years agosource-copyright: Use line numbers instead of paragraph numbers
Niels Thykier [Tue, 14 Feb 2012 21:10:42 +0000 (22:10 +0100)]
source-copyright: Use line numbers instead of paragraph numbers

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoUtil.pm: Report line number in syntax errors of dctrl files
Niels Thykier [Tue, 14 Feb 2012 20:05:59 +0000 (21:05 +0100)]
Util.pm: Report line number in syntax errors of dctrl files

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoClarify the legal status of copyright notices in long tag desc
Russ Allbery [Sun, 12 Feb 2012 20:47:56 +0000 (12:47 -0800)]
Clarify the legal status of copyright notices in long tag desc

* checks/copyright.desc:
  + [RA] Rephrase copyright-with-old-dh-make-debian-copyright long
    description to be clearer about the legal status of copyright
    notices.  (Closes: #659574)

2 years agodh_commnads-manual: Added entry for dh_xine
Niels Thykier [Fri, 10 Feb 2012 12:03:34 +0000 (13:03 +0100)]
dh_commnads-manual: Added entry for dh_xine

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoL::Tags::_record_stats: Count experimental tags separately
Niels Thykier [Fri, 10 Feb 2012 10:25:39 +0000 (11:25 +0100)]
L::Tags::_record_stats: Count experimental tags separately

Count experimental tags as a separate group of tags.  This fixes an
issue where Lintian would exit 1 if the only error tags emitted were
experimental.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemove internal locale on upgrade/trigger if no longer needed
Niels Thykier [Fri, 10 Feb 2012 09:53:43 +0000 (10:53 +0100)]
Remove internal locale on upgrade/trigger if no longer needed

Added a trigger on /usr/lib/locale/C.UTF-8 locale to catch cases like
libc-bin being upgraded to 2.13 after Lintian 2.5.5.  Prefer libc-bin
(>= 2.13) to locales in dependencies.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agop/runtests: Generate en_US.UTF-8 locale instead of C.UTF-8
Niels Thykier [Fri, 10 Feb 2012 09:03:23 +0000 (10:03 +0100)]
p/runtests: Generate en_US.UTF-8 locale instead of C.UTF-8

It is not possible to generate the C.UTF-8 locale on Squeeze systems
and Lintian needs either C.UTF-8 or en_US.UTF-8 to pass the certain
tests (like manpages-general).

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agop/runtests: Generate locale only if needed
Niels Thykier [Thu, 9 Feb 2012 20:41:54 +0000 (21:41 +0100)]
p/runtests: Generate locale only if needed

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoUtil: Fix stupid error in clean_env
Niels Thykier [Thu, 9 Feb 2012 20:34:31 +0000 (21:34 +0100)]
Util: Fix stupid error in clean_env

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agochecks/infofiles: Use clean_env after fork
Niels Thykier [Thu, 9 Feb 2012 19:58:24 +0000 (20:58 +0100)]
checks/infofiles: Use clean_env after fork

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoUtil: Make clean_env optionally set LC_ALL
Niels Thykier [Thu, 9 Feb 2012 19:54:45 +0000 (20:54 +0100)]
Util: Make clean_env optionally set LC_ALL

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoUtil: Added clean_env sub to clean %ENV using a whitelist
Niels Thykier [Thu, 9 Feb 2012 15:59:29 +0000 (16:59 +0100)]
Util: Added clean_env sub to clean %ENV using a whitelist

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdded test for no-upstream-changelog
Niels Thykier [Thu, 9 Feb 2012 14:56:01 +0000 (15:56 +0100)]
Added test for no-upstream-changelog

The check was lost as a side-effect of commit dde19e4.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoCheck for ELF binaries in unsafe paths in M-A same packages
Jakub Wilk [Wed, 8 Feb 2012 16:12:37 +0000 (17:12 +0100)]
Check for ELF binaries in unsafe paths in M-A same packages

Modification to original patch:
 * Also assume "/.build-id/" dirs to be safe.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoTreat pedantic the same as all other severities
Niels Thykier [Wed, 8 Feb 2012 09:56:58 +0000 (10:56 +0100)]
Treat pedantic the same as all other severities

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdd checks for certainty and severity in L::T::Info::new
Niels Thykier [Wed, 8 Feb 2012 08:48:46 +0000 (09:48 +0100)]
Add checks for certainty and severity in L::T::Info::new

This catches an incorrect .desc file for checks as soon as it is
loaded.  It also makes a couple of other "certainty/severity" checks
redundant.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoL::Profile: s/turth/truth/ fix
Niels Thykier [Tue, 7 Feb 2012 10:03:41 +0000 (11:03 +0100)]
L::Profile: s/turth/truth/ fix

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agolintian: Reduce the use of L::DepMap for checks
Niels Thykier [Tue, 7 Feb 2012 10:00:08 +0000 (11:00 +0100)]
lintian: Reduce the use of L::DepMap for checks

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agolintianrc.example: Remove deprecated vars and add TMPDIR
Niels Thykier [Sat, 4 Feb 2012 18:12:28 +0000 (19:12 +0100)]
lintianrc.example: Remove deprecated vars and add TMPDIR

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agolintian: Allow TMPDIR in the configuration file
Niels Thykier [Sat, 4 Feb 2012 17:42:54 +0000 (18:42 +0100)]
lintian: Allow TMPDIR in the configuration file

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agolintian: Fixed a regression in parsing LINTIAN_ conf options
Niels Thykier [Sat, 4 Feb 2012 16:51:11 +0000 (17:51 +0100)]
lintian: Fixed a regression in parsing LINTIAN_ conf options

Remove a leftover '$var = "LINTIAN_$var"' that broke the names
of some (apparently unused) configuration options.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoLab: Fix tempdir invocation and extended the tempdir template
Niels Thykier [Sat, 4 Feb 2012 16:42:16 +0000 (17:42 +0100)]
Lab: Fix tempdir invocation and extended the tempdir template

Fix the call of tempdir in L::Lab::create so it actually receives the
options passed to it.  Also extended the randomizable part of the
template to 10 (from 6).

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoWork around dpkg-source hardcoding gpg{,v} paths
Niels Thykier [Sat, 4 Feb 2012 15:57:00 +0000 (16:57 +0100)]
Work around dpkg-source hardcoding gpg{,v} paths

dpkg-source hardcodes the paths to gpg (and gpgv).  To fix this,
harness exports a magic/internal env variable if signature checks are
to be skipped.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agolib/Lintian/Processable.pm: add missing word
Adam D. Barratt [Sat, 4 Feb 2012 15:49:38 +0000 (15:49 +0000)]
lib/Lintian/Processable.pm: add missing word

Signed-off-by: Adam D. Barratt <adam@adam-barratt.org.uk>
2 years agoMinor fixup of L::Processable{,::Package}
Niels Thykier [Sat, 4 Feb 2012 15:22:14 +0000 (16:22 +0100)]
Minor fixup of L::Processable{,::Package}

Remove an unused constant and fixed a documentation typo.  Fixed
info caching for L::P::Package and revised L::P info.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoharness: Also handle gpgv with $LINTIAN_GPG_CHECK
Niels Thykier [Sat, 4 Feb 2012 14:56:30 +0000 (15:56 +0100)]
harness: Also handle gpgv with $LINTIAN_GPG_CHECK

Apparently dpkg-source prefers gpgv to gpg, so ensure that gpgv is
also linked to /bin/true when skipping gpg checks.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agocruft: Do now open symlinks when checking waf files
Niels Thykier [Sat, 4 Feb 2012 13:53:31 +0000 (14:53 +0100)]
cruft: Do now open symlinks when checking waf files

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agocruft: Double check waf files if file(1) says ok
Niels Thykier [Sat, 4 Feb 2012 13:14:30 +0000 (14:14 +0100)]
cruft: Double check waf files if file(1) says ok

Unfortunately file 5.04 (Squeeze) says the waf file in the Lintian
test suite is "python" and not "data".

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoc/file-info: pass -N to file(1) to avoid output alignment
Niels Thykier [Sat, 4 Feb 2012 12:31:52 +0000 (13:31 +0100)]
c/file-info: pass -N to file(1) to avoid output alignment

For packages with long filenames the alignment can be a considerably
part of the size (e.g. the lintian/2.5.4 source).

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoEmit spelling tags only once per error per field/file/text
Niels Thykier [Fri, 3 Feb 2012 21:26:12 +0000 (22:26 +0100)]
Emit spelling tags only once per error per field/file/text

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoharness: Skip sources if there are no binaries referencing them
Niels Thykier [Sat, 21 Jan 2012 18:59:32 +0000 (19:59 +0100)]
harness: Skip sources if there are no binaries referencing them

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdd separate tag for not having a debhelper compat file
Niels Thykier [Fri, 3 Feb 2012 11:31:48 +0000 (12:31 +0100)]
Add separate tag for not having a debhelper compat file

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoFix ordering of some changelog entries
Niels Thykier [Fri, 3 Feb 2012 10:52:28 +0000 (11:52 +0100)]
Fix ordering of some changelog entries

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemove the *-not-full-name checks (Closes: #658031).
intrigeri [Mon, 30 Jan 2012 22:14:56 +0000 (23:14 +0100)]
Remove the *-not-full-name checks (Closes: #658031).

Acked-by: Niels Thykier <niels@thykier.net>
2 years agoCheck for commented out collab-maint Vcs-* headers.
Gergely Nagy [Tue, 24 Jan 2012 09:30:28 +0000 (10:30 +0100)]
Check for commented out collab-maint Vcs-* headers.

dh_make adds commented out Vcs-* header boilerplate to debian/control,
which should either be removed, or changed to be a valid location.

This check implements just that.

Modifications to the original patch:
 - tidied the regex a bit
 - renamed to tag control-file
 - only emit the tag once per file/package

Requested-By: Paul Wise <pabs@debian.org>
Signed-off-by: Gergely Nagy <algernon@balabit.hu>
Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoLintian::Lab: Use section instead of const value for area value
Niels Thykier [Thu, 2 Feb 2012 21:41:44 +0000 (22:41 +0100)]
Lintian::Lab: Use section instead of const value for area value

Fixed an issue where the constant "main" was used in the metadata of
binary packages.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoFixed TRIPLETT -> TRIPLET typo in various test files
Jakub Wilk [Thu, 2 Feb 2012 21:24:10 +0000 (22:24 +0100)]
Fixed TRIPLETT -> TRIPLET typo in various test files

Acked-by: Niels Thykier <niels@thykier.net>
2 years agoLintian::Lab: Added repair_lab method
Niels Thykier [Wed, 1 Feb 2012 13:49:36 +0000 (14:49 +0100)]
Lintian::Lab: Added repair_lab method

This is able to correct lab indices referring to entries that are
either broken or does not exist.  The solution is to remove the
metadata reference and the remains of the entry (if any).

It lacks a check for packages present in the lab that does not appear
in the relevant index.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoharness: Skip some actions in dry-run
Niels Thykier [Wed, 1 Feb 2012 12:40:48 +0000 (13:40 +0100)]
harness: Skip some actions in dry-run

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoFix broken Log in dry-run and some uses of Die
Niels Thykier [Wed, 1 Feb 2012 11:34:09 +0000 (12:34 +0100)]
Fix broken Log in dry-run and some uses of Die

In dry-run mode it now opens the LOG descriptor used by the Log
function.  As Die (not to be confused with die) uses Log to output an
error, it should not be used before the log file has been opened.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRe-added swfobjects.js to list of known javascript libraries
Niels Thykier [Wed, 1 Feb 2012 10:29:45 +0000 (11:29 +0100)]
Re-added swfobjects.js to list of known javascript libraries

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoharness: Added --dry-run option
Niels Thykier [Wed, 1 Feb 2012 00:04:43 +0000 (01:04 +0100)]
harness: Added --dry-run option

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoharness: Use Getopt::Long for cmd args and add --help
Niels Thykier [Tue, 31 Jan 2012 23:06:17 +0000 (00:06 +0100)]
harness: Use Getopt::Long for cmd args and add --help

Migrate to Getopt::Long - this means all frontends (that parse
arguments) all use the same option parser.

Add --help/-h for consistency with the other frontends and because
otherwise you would have to give invalid arguments to get usage info.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agohtml_reports: Index only source packages in packages_$i.html
Niels Thykier [Tue, 31 Jan 2012 20:48:33 +0000 (21:48 +0100)]
html_reports: Index only source packages in packages_$i.html

This reduces the amount of packages in each "packages_$i.html" a
bit.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoIgnore missing symbols/shlibs files for libc libnss plugins
Niels Thykier [Sat, 28 Jan 2012 19:25:47 +0000 (20:25 +0100)]
Ignore missing symbols/shlibs files for libc libnss plugins

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoUpdated regex in lib_soname_path
Niels Thykier [Sat, 28 Jan 2012 19:09:42 +0000 (20:09 +0100)]
Updated regex in lib_soname_path

Recognise some libnss plugins are installed in {,usr/}lib{,32,64}.
Remove unneeded check for leading "./" in paths.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdded "tls" to hwcap-dirs via "Keep:"
Niels Thykier [Sat, 28 Jan 2012 17:47:46 +0000 (18:47 +0100)]
Added "tls" to hwcap-dirs via "Keep:"

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoshared-libs: Move hwcap-dirs into a data-file
Jakub Wilk [Sat, 28 Jan 2012 17:36:57 +0000 (18:36 +0100)]
shared-libs: Move hwcap-dirs into a data-file

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoDrop usr/X11R6/lib from ldconfig-dirs
Niels Thykier [Sat, 28 Jan 2012 15:36:45 +0000 (16:36 +0100)]
Drop usr/X11R6/lib from ldconfig-dirs

It is no longer in /etc/ld.so.conf (nor in the .d dir).

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoImplemented "soruce-contains-waf-binary" tag
Luca Falavigna [Sat, 28 Jan 2012 15:35:15 +0000 (16:35 +0100)]
Implemented "soruce-contains-waf-binary" tag

Acked-by: Niels Thykier <niels@thykier.net>
2 years agoRewrote refresh-archs, auto-generated ldconfig-dirs
Niels Thykier [Sat, 28 Jan 2012 14:11:43 +0000 (15:11 +0100)]
Rewrote refresh-archs, auto-generated ldconfig-dirs

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoFixed a regression in testset/runtests (caused by the last commit)
Niels Thykier [Sat, 28 Jan 2012 13:57:56 +0000 (14:57 +0100)]
Fixed a regression in testset/runtests (caused by the last commit)

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoPass LINTIAN_ROOT to constructor of Lintian::Profile
Niels Thykier [Sat, 28 Jan 2012 11:06:58 +0000 (12:06 +0100)]
Pass LINTIAN_ROOT to constructor of Lintian::Profile

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdded changelog entries and uploaded the manpage
Niels Thykier [Fri, 27 Jan 2012 14:36:51 +0000 (15:36 +0100)]
Added changelog entries and uploaded the manpage

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoL::Tags: remove suppress and only methods
Niels Thykier [Fri, 27 Jan 2012 14:20:32 +0000 (15:20 +0100)]
L::Tags: remove suppress and only methods

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoReplaced %check_info/%enabled_checks with profiles
Niels Thykier [Wed, 18 Jan 2012 12:02:54 +0000 (13:02 +0100)]
Replaced %check_info/%enabled_checks with profiles

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemoved Checker module and reduced the "magic" of LINTIAN_ROOT
Niels Thykier [Wed, 18 Jan 2012 10:16:46 +0000 (11:16 +0100)]
Removed Checker module and reduced the "magic" of LINTIAN_ROOT

The code from the Checker module has been inlined into its own sub in
frontend/lintian.  The extra module did not reduce the size of
f/lintian notabily and it allowed a reduction in the ways we propagate
LINTIAN_ROOT to modules.

Previously LINTIAN_ROOT needed to be exported as an ENV variable AND
as an "our $LINTIAN_ROOT".  Now, only the ENV variable is needed.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoMade suppress checks and suppress checks go through the profile
Niels Thykier [Wed, 18 Jan 2012 09:41:37 +0000 (10:41 +0100)]
Made suppress checks and suppress checks go through the profile

The work still duplicated further down in the code, but will be
removed in a later commit.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemove unused code in Lintian::Info::Tag
Niels Thykier [Wed, 18 Jan 2012 00:13:45 +0000 (01:13 +0100)]
Remove unused code in Lintian::Info::Tag

Removal of the Lintian::Info::Tag (TAG) constructor and the now
redundant _load_tag_data.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAlways load a profile and stop using Lintian::Info::Tag (TAG)
Niels Thykier [Wed, 18 Jan 2012 00:05:26 +0000 (01:05 +0100)]
Always load a profile and stop using Lintian::Info::Tag (TAG)

frontend/lintian will now always load a profile.  This allows
all tag look-ups to go through profiles and removes the need
for the Lintian::Info::Tag (TAG) constructor.

In order to keep this patch small, it leaves some now (almost)
redundant code that will be removed in a later commit (notiably
including the above mentioned constructor).

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoMade profiles a "tag-container" and use profiles more widely
Niels Thykier [Tue, 17 Jan 2012 18:35:38 +0000 (19:35 +0100)]
Made profiles a "tag-container" and use profiles more widely

Previously tags were stored in a private static variable in
Lintian::Tags.  Unfortunately, Lintian::Tags, Lintian::Profile and
reporting/html_reports manually accessed the check dir for various
reasons.

To solve this, Lintian::Profile is now the primary method of obtaining
tag info.  There is a single unhandled case in f/lintian (propagating
to Lintian::Tags), where no profile is loaded and the old method is
still used.

Some important changes:
 * Lintian::Profile now applies severity changes directly.
 * Lintian::Tags can work directly with a profile, which reduces a bit
   of glue code between the two modules in f/lintian.
 * The (reporting) templates now get the Lintian profile (as $profile).
   This replaces the "%all" hash (only used to iterate over all known
   tags in r/t/tags-all.tmpl).

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdded Class for representing "Check Scripts"
Niels Thykier [Tue, 17 Jan 2012 14:36:48 +0000 (15:36 +0100)]
Added Class for representing "Check Scripts"

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoFixed an uninitialized variable issue in L::Lab::Entry
Niels Thykier [Tue, 24 Jan 2012 15:35:08 +0000 (16:35 +0100)]
Fixed an uninitialized variable issue in L::Lab::Entry

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAllow self relations in Replaces and Provides (per §7.6.2)
Niels Thykier [Mon, 23 Jan 2012 16:44:03 +0000 (17:44 +0100)]
Allow self relations in Replaces and Provides (per §7.6.2)

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoGracefully handle syntax errors in debconf templates
Niels Thykier [Fri, 20 Jan 2012 15:43:43 +0000 (16:43 +0100)]
Gracefully handle syntax errors in debconf templates

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoGracefully handle syntax errors in d/control
Niels Thykier [Sat, 21 Jan 2012 18:46:56 +0000 (19:46 +0100)]
Gracefully handle syntax errors in d/control

Lintian::Collect::Source will now ignore syntax errors in d/control
(but not other errors).  Instead it will "assume" the file to be
"empty" (for the purpose of determining binaries/binary fields).

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoAdded pod to L::Collect::Group and fixed copyright
Niels Thykier [Sun, 22 Jan 2012 21:13:39 +0000 (22:13 +0100)]
Added pod to L::Collect::Group and fixed copyright

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoImproved the documentation of Lintian::Lab
Niels Thykier [Sun, 22 Jan 2012 14:29:01 +0000 (15:29 +0100)]
Improved the documentation of Lintian::Lab

Also forbid an empty "Layout" field in L::Lab::open.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemoved dh_dhelp-is-deprecated tag
Niels Thykier [Sun, 22 Jan 2012 13:10:04 +0000 (14:10 +0100)]
Removed dh_dhelp-is-deprecated tag

The debhelper package no longer ships dh_dhelp (not even in Squeeze).
According to lintian.d.o, the tag is no longer emitted.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemoved two tags related to wm-menu{,-config}
Niels Thykier [Sun, 22 Jan 2012 12:54:57 +0000 (13:54 +0100)]
Removed two tags related to wm-menu{,-config}

The menu package no longer ships these executables (not even in
Squeeze).  According to lintian.d.o, the tags are no longer
emitted.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemoved reference to the removed "unpack" dir in README.dev
Niels Thykier [Sun, 22 Jan 2012 11:51:16 +0000 (12:51 +0100)]
Removed reference to the removed "unpack" dir in README.dev

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoc/cruft: properly handle unpacked being a symlink
Niels Thykier [Sun, 22 Jan 2012 11:14:32 +0000 (12:14 +0100)]
c/cruft: properly handle unpacked being a symlink

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRemoved assumption unpacked being a regular dir in some colls
Niels Thykier [Sun, 22 Jan 2012 10:26:27 +0000 (11:26 +0100)]
Removed assumption unpacked being a regular dir in some colls

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoTypo fix
Adam D. Barratt [Thu, 19 Jan 2012 21:29:51 +0000 (21:29 +0000)]
Typo fix

Signed-off-by: Adam D. Barratt <adam@adam-barratt.org.uk>
2 years agoFixed a typo in the changelog
Niels Thykier [Thu, 19 Jan 2012 13:48:21 +0000 (14:48 +0100)]
Fixed a typo in the changelog

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoMore typo fixing
Niels Thykier [Thu, 19 Jan 2012 13:35:19 +0000 (14:35 +0100)]
More typo fixing

I can't even spell my own name anymore! T_T

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoExplicitly say that profile directories are searched in order
Niels Thykier [Thu, 19 Jan 2012 13:25:25 +0000 (14:25 +0100)]
Explicitly say that profile directories are searched in order

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoTypo fixes in the Manual
Niels Thykier [Thu, 19 Jan 2012 13:25:11 +0000 (14:25 +0100)]
Typo fixes in the Manual

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRecognize more Perl debconf usages
Russ Allbery [Thu, 19 Jan 2012 04:30:57 +0000 (20:30 -0800)]
Recognize more Perl debconf usages

* checks/debconf:
  + [RA] Recognize Perl uses of debconf templates via metaget or
    settitle.

2 years agoInclude ssh:// as valid protocol for hg
Jakub Wilk [Wed, 18 Jan 2012 22:13:02 +0000 (23:13 +0100)]
Include ssh:// as valid protocol for hg

Acked-by: Niels Thykier <niels@thykier.net>
2 years agolintian-info: Fixed the --profile argument
Niels Thykier [Wed, 18 Jan 2012 12:44:00 +0000 (13:44 +0100)]
lintian-info: Fixed the --profile argument

It now accepts the mandatory parameter it is supposed to.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoProperly strip comments and empty lines from suppress tags files
Niels Thykier [Wed, 18 Jan 2012 09:40:09 +0000 (10:40 +0100)]
Properly strip comments and empty lines from suppress tags files

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoReworded two lines of the documentation
Niels Thykier [Tue, 17 Jan 2012 13:37:59 +0000 (14:37 +0100)]
Reworded two lines of the documentation

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoRefreshed ancient S-V date
Niels Thykier [Tue, 17 Jan 2012 18:59:22 +0000 (19:59 +0100)]
Refreshed ancient S-V date

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoL::Profile: Improve the "recursive definition"-check
Niels Thykier [Wed, 11 Jan 2012 14:32:13 +0000 (15:32 +0100)]
L::Profile: Improve the "recursive definition"-check

Catch profiles that are recursively defined, but where the Profile
field of the child and Extend field of the parent are not identical.
This can happen if one profile uses "$vendor" and another uses
"$vendor/main" or if symlinks are involved.

This patch solves the issue by deferring the check until the child
profile has been read.  Then it can use the Profile field as the
"canonical" name for the profile.

Note the parents field will use the value in the Extends field and not
the Profile field in the child profile.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoCorrected any-CPU wildcards for some archs
Niels Thykier [Sun, 8 Jan 2012 09:11:55 +0000 (10:11 +0100)]
Corrected any-CPU wildcards for some archs

This is done by mapping architecture names to their "DEB_HOST_ARCH_OS"
and "DEB_HOST_ARCH_CPU" values and using those to determine the
wildcards.

Previously architecture wildcards were determined from the Debian
arch by splitting the architecture by "-" and using the result to
define "OS-any" and "any-CPU".

This relies on the assumption that the CPU wildcard has the exact same
CPU name as the Debian arch.  Unfortunately, this assumption is
invalid for some cases (e.g. armel and lpia)[1].

[1] This can be confirmed by using dpkg-architecture:

 $ dpkg-architecture -aarmel -iany-armel && echo yes
 $ dpkg-architecture -aarmel -iany-arm && echo yes
 yes

 $ dpkg-architecture -alpia -iany-lpia && echo yes
 $ dpkg-architecture -alpia -iany-i386 && echo yes
 yes

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoharness: Set environment variables before including other modules
Evan Broder [Mon, 26 Dec 2011 17:48:34 +0000 (09:48 -0800)]
harness: Set environment variables before including other modules

Signed-off-by: Evan Broder <evan@ebroder.net>
2 years agoSet $ENV{LINTIAN_ROOT} in generate-lintian-pod
Niels Thykier [Fri, 23 Dec 2011 20:49:47 +0000 (21:49 +0100)]
Set $ENV{LINTIAN_ROOT} in generate-lintian-pod

Lintian::Architecture is indirectly loaded and uses Lintian::Data,
which assumes $ENV{LINTIAN_ROOT} is set.  Set $ENV{LINTIAN_ROOT} to
work around the "uninitialized variable" warnings.

Signed-off-by: Niels Thykier <niels@thykier.net>
2 years agoDocumented architecture specific overrides
Niels Thykier [Fri, 23 Dec 2011 20:46:27 +0000 (21:46 +0100)]
Documented architecture specific overrides

Signed-off-by: Niels Thykier <niels@thykier.net>